Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent accidental calls in large groups (WPB-4293) #2216

Merged
merged 9 commits into from
Sep 12, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 12, 2023

StoryWPB-4293 [Android] Prevent accidental calls in large groups


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

For large groups (>5 participants), the app will display a confirmation dialog before starting a call to prevent accidental clicks

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Start a call in a large group ( more than 4 participants)

Attachments (Optional)

Wire 2023-09-12 at 11_36 AM


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Test Results

600 tests  ±0   599 ✔️ ±0   4m 47s ⏱️ - 1m 17s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit efbf600. ± Comparison against base commit 07cab37.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 697 failed.

@AndroidBob
Copy link
Collaborator

Build 699 failed.

@ohassine ohassine requested review from a team, gongracr, yamilmedina, borichellow, vitorhugods and saleniuk and removed request for a team September 12, 2023 11:53
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@AndroidBob
Copy link
Collaborator

Build 708 failed.

@@ -96,7 +97,7 @@ fun WireDialog(
optionButton2Properties = optionButton2Properties,
dismissButtonProperties = dismissButtonProperties,
buttonsHorizontalAlignment = buttonsHorizontalAlignment,
modifier = modifier,
modifier = modifier.semantics(mergeDescendants = true) {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: what does it do exactly for the dialog? 🤔

Copy link
Member Author

@ohassine ohassine Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for accessibility. When the dialog is displayed, Talkback will read all of its content not just the title

@AndroidBob
Copy link
Collaborator

Build 716 failed.

@ohassine ohassine added this pull request to the merge queue Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #2216 (efbf600) into develop (07cab37) will increase coverage by 0.02%.
Report is 3 commits behind head on develop.
The diff coverage is 70.00%.

@@              Coverage Diff              @@
##             develop    #2216      +/-   ##
=============================================
+ Coverage      40.86%   40.89%   +0.02%     
- Complexity       996      997       +1     
=============================================
  Files            310      310              
  Lines          11420    11430      +10     
  Branches        1524     1525       +1     
=============================================
+ Hits            4667     4674       +7     
- Misses          6313     6316       +3     
  Partials         440      440              
Files Changed Coverage Δ
...me/conversations/call/ConversationCallViewModel.kt 56.66% <66.66%> (+1.11%) ⬆️
...me/conversations/call/ConversationCallViewState.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07cab37...efbf600. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@AndroidBob
Copy link
Collaborator

Build 722 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Sep 12, 2023
Merged via the queue into develop with commit ead2204 Sep 12, 2023
11 checks passed
@ohassine ohassine deleted the Prevent_accidental_calls_in_large_groups branch September 12, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants