-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prevent accidental calls in large groups (WPB-4293) #2216
Conversation
Build 697 failed. |
Build 699 failed. |
Build 708 failed. |
@@ -96,7 +97,7 @@ fun WireDialog( | |||
optionButton2Properties = optionButton2Properties, | |||
dismissButtonProperties = dismissButtonProperties, | |||
buttonsHorizontalAlignment = buttonsHorizontalAlignment, | |||
modifier = modifier, | |||
modifier = modifier.semantics(mergeDescendants = true) {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what does it do exactly for the dialog? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for accessibility. When the dialog is displayed, Talkback will read all of its content not just the title
Build 716 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2216 +/- ##
=============================================
+ Coverage 40.86% 40.89% +0.02%
- Complexity 996 997 +1
=============================================
Files 310 310
Lines 11420 11430 +10
Branches 1524 1525 +1
=============================================
+ Hits 4667 4674 +7
- Misses 6313 6316 +3
Partials 440 440
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 722 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Description
For large groups (>5 participants), the app will display a confirmation dialog before starting a call to prevent accidental clicks
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Start a call in a large group ( more than 4 participants)
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.