-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable translations in plurals for failed to add and failed to send messages (WPB-3788) #2173
Conversation
…end messages (WPB-3788) (#2170)
APKs built during tests are available here. Scroll down to Artifacts! |
Codecov Report
@@ Coverage Diff @@
## develop #2173 +/- ##
=============================================
- Coverage 40.95% 40.94% -0.01%
Complexity 994 994
=============================================
Files 310 310
Lines 11386 11388 +2
Branches 1518 1519 +1
=============================================
Hits 4663 4663
- Misses 6283 6284 +1
- Partials 440 441 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 523 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We need to be able to properly translate in plurals for other supported languages, ie: German, Spanish, etc.
Solutions
Add plurals versions to strings for failed to add and partial failed to send.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.