Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable translations in plurals for failed to add and failed to send messages (WPB-3788) #2173

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2023

TaskWPB-3788 [Android] Review/update strings and translations for federation release

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to be able to properly translate in plurals for other supported languages, ie: German, Spanish, etc.

Solutions

Add plurals versions to strings for failed to add and partial failed to send.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Sep 4, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2023

Test Results

596 tests  ±0   595 ✔️ ±0   5m 38s ⏱️ - 2m 16s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit 3ec036c. ± Comparison against base commit 780f878.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Sep 4, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2173 (3ec036c) into develop (780f878) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #2173      +/-   ##
=============================================
- Coverage      40.95%   40.94%   -0.01%     
  Complexity       994      994              
=============================================
  Files            310      310              
  Lines          11386    11388       +2     
  Branches        1518     1519       +1     
=============================================
  Hits            4663     4663              
- Misses          6283     6284       +1     
- Partials         440      441       +1     
Files Changed Coverage Δ
...e/android/ui/home/conversations/model/UIMessage.kt 57.92% <33.33%> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 780f878...3ec036c. Read the comment docs.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
@AndroidBob
Copy link
Collaborator

Build 523 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 5aafdea Sep 4, 2023
11 checks passed
@yamilmedina yamilmedina deleted the fix/adjust-messages-strings-cherry-pick branch September 4, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants