Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken jira action link (WPB-3906) #2172

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Sep 4, 2023

EpicWPB-3906 [Android] Code Refactoring


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Jira link is broken since July 12th

Solutions

Fix it

How to Test

A link should appear linked in this PR.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Sep 4, 2023
@yamilmedina yamilmedina requested review from a team, typfel, gongracr, vitorhugods, Garzas and trOnk12 and removed request for a team September 4, 2023 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Test Results

596 tests  ±0   595 ✔️ ±0   6m 35s ⏱️ - 1m 20s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit 1c89ebc. ± Comparison against base commit 7203689.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Sep 4, 2023
Merged via the queue into develop with commit 780f878 Sep 4, 2023
12 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/fix-jira-lint branch September 4, 2023 14:36
@AndroidBob
Copy link
Collaborator

Build 509 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants