Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: empty line #2171

Closed
wants to merge 9 commits into from
Closed

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 4, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Test Results

596 tests   595 ✔️  4m 13s ⏱️
  85 suites      1 💤
  85 files        0

Results for commit ad39a12.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 5, 2023
…e_to_gradle_8-1-test

# Conflicts:
#	AR-builder.groovy
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #2171 (ad39a12) into upgrade_to_gradle_8 (c0cb4de) will increase coverage by 0.23%.
Report is 41 commits behind head on upgrade_to_gradle_8.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##             upgrade_to_gradle_8    #2171      +/-   ##
=========================================================
+ Coverage                  40.71%   40.95%   +0.23%     
- Complexity                   981      994      +13     
=========================================================
  Files                        310      310              
  Lines                      11369    11386      +17     
  Branches                    1517     1518       +1     
=========================================================
+ Hits                        4629     4663      +34     
+ Misses                      6300     6283      -17     
  Partials                     440      440              
Files Changed Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt 0.00% <ø> (ø)
.../wire/android/ui/home/messagecomposer/UiMention.kt 0.00% <ø> (ø)
...c/main/kotlin/com/wire/android/util/FileManager.kt 13.23% <ø> (ø)
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% <ø> (ø)
...d/util/permission/CallingRecordAudioRequestFlow.kt 0.00% <ø> (ø)
...e/android/ui/calling/incoming/IncomingCallState.kt 100.00% <100.00%> (ø)
...droid/ui/calling/incoming/IncomingCallViewModel.kt 85.89% <100.00%> (+0.76%) ⬆️
...me/conversations/call/ConversationCallViewModel.kt 55.55% <100.00%> (+2.30%) ⬆️
...me/conversations/call/ConversationCallViewState.kt 100.00% <100.00%> (ø)
...ui/home/conversationslist/ConversationListState.kt 94.11% <100.00%> (+0.36%) ⬆️
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2986e67...ad39a12. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Sep 5, 2023
@AndroidBob
Copy link
Collaborator

Build 557 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 558 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 560 failed.

@ohassine ohassine closed this Sep 5, 2023
@ohassine ohassine deleted the upgrade_to_gradle_8-1-test branch April 8, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants