Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share text to wire (WPB-1872) #2168

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When selecting to share a text (guest links), there was no possibility to select Wire from the popup menu.

Causes (Optional)

Was not implemented.

Solutions

Add possibility to share text/* to Wire, now when importing/sharing asset(also text) we are verifying if it is text and send it as a normal message.

Testing

How to Test

  • have a group conversation where you are admin
  • tap on group details > guests > enable link to share
  • tap on share button
  • select Wire in the app drawer
  • select a conversation to share it with in wire
  • send button should be enabled and the user should be able to share links through wire.
  • the user should also be able to send text file through wire.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Test Results

596 tests  ±0   595 ✔️ ±0   7m 48s ⏱️ -7s
  85 suites ±0       1 💤 ±0 
  85 files   ±0       0 ±0 

Results for commit c5824e3. ± Comparison against base commit 7203689.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2168 (c5824e3) into develop (7203689) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2168      +/-   ##
=============================================
- Coverage      40.95%   40.90%   -0.06%     
  Complexity       994      994              
=============================================
  Files            310      310              
  Lines          11386    11400      +14     
  Branches        1518     1519       +1     
=============================================
  Hits            4663     4663              
- Misses          6283     6297      +14     
  Partials         440      440              
Files Changed Coverage Δ
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7203689...c5824e3. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris requested review from a team, typfel, gongracr, yamilmedina, vitorhugods and saleniuk and removed request for a team September 4, 2023 11:14
@AndroidBob
Copy link
Collaborator

Build 495 succeeded.

The build produced the following APK's:

@alexandreferris alexandreferris added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2023
@ohassine ohassine added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit a19f4b4 Sep 5, 2023
10 checks passed
@ohassine ohassine deleted the fix/share_text_to_wire branch September 5, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants