-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calling): request audio and BT permission on start, join or accept call (WPB-1809) (WPB-3961) #2160
Conversation
Build 443 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #2160 +/- ##
=============================================
+ Coverage 40.71% 40.79% +0.07%
- Complexity 981 990 +9
=============================================
Files 310 310
Lines 11369 11384 +15
Branches 1517 1517
=============================================
+ Hits 4629 4644 +15
Misses 6300 6300
Partials 440 440
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 445 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing work!
...src/main/kotlin/com/wire/android/ui/home/messagecomposer/recordaudio/RecordAudioComponent.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 460 succeeded. The build produced the following APK's: |
…pt call (WPB-1809) (WPB-3961) (#2160)
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
This PR aims to request audio/BT permission on every action related to calling(join, answer or start)
If the user decline the permission twice, it will be considered as permanent deny and we will display a dialog containing a button to redirect to app info in settings
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Try to start a call and reject permissions every time it's requested
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.