Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when changing the timer from a value to off in the file sharing screen the button state is not updated correctly [WPB-405] #2156

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

when changing the timer from a value to off in the file sharing screen the button state is not updated correctly

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested review from Garzas, a team, alexandreferris, trOnk12, ohassine and saleniuk and removed request for a team August 30, 2023 14:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Test Results

583 tests   582 ✔️  8m 27s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit 64f660a.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 424 failed.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 433 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge (squash) August 31, 2023 08:38
@MohamadJaara MohamadJaara merged commit 45137f6 into release/candidate Sep 1, 2023
5 of 6 checks passed
@MohamadJaara MohamadJaara deleted the fix/WPB-405 branch September 1, 2023 10:21
github-actions bot pushed a commit that referenced this pull request Sep 1, 2023
…screen the button state is not updated correctly [WPB-405] (#2156)
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 465 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants