Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missed activity icon size (WPB-3896) #2140

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Conversation icons were misaligned on height dimension

Solutions

Adjust height of icons to match with Unread Messages icon+text

How to Test

  • Open App
  • Receive (Reply, Mention, Ping, Normal messages) and verify each shown icon

Attachments (Optional)

Before After
Screenshot 2023-08-28 at 16 54 49 Screenshot 2023-08-28 at 17 00 02

@alexandreferris alexandreferris changed the title fix: missed activity icon size fix: missed activity icon size (WPB-3896) Aug 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Test Results

583 tests  ±0   582 ✔️ ±0   7m 14s ⏱️ +38s
  84 suites ±0       1 💤 ±0 
  84 files   ±0       0 ±0 

Results for commit 64d1a0b. ± Comparison against base commit 31b5e66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris requested review from a team, yamilmedina, MohamadJaara, mchenani, Garzas and trOnk12 and removed request for a team August 28, 2023 15:47
@alexandreferris alexandreferris added this pull request to the merge queue Aug 29, 2023
Merged via the queue into develop with commit 8e8d91f Aug 29, 2023
10 checks passed
@alexandreferris alexandreferris deleted the fix/missed_activity_icon_size branch August 29, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants