Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config crowdin action #2137

Merged
merged 6 commits into from
Aug 29, 2023
Merged

chore: config crowdin action #2137

merged 6 commits into from
Aug 29, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 28, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently, we depend on a number of users with priveleges, that can trigger sync from crowdin to the repo.

Causes (Optional)

With this action, we can now trigger PR localization update.

  • Executing a manual workflow execution as an alternative, to target either develop as default or release candidate
  • Pushing to develop triggers automatically the sync (feature maintained)
  • Assign the android team as a reviewer

Testing

You can see at the execution from the fork I tested.
https://github.com/yamilmedina/wire-android-reloaded/pulls

Screenshot 2023-08-28 at 18 31 41


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Test Results

583 tests  ±0   582 ✔️ ±0   7m 18s ⏱️ +42s
  84 suites ±0       1 💤 ±0 
  84 files   ±0       0 ±0 

Results for commit 24d0e71. ± Comparison against base commit 31b5e66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina marked this pull request as ready for review August 28, 2023 16:11
@yamilmedina yamilmedina requested review from a team, typfel, gongracr, alexandreferris, trOnk12, saleniuk, vitorhugods and tmspzz and removed request for a team and trOnk12 August 28, 2023 16:19
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍷 work :)

@yamilmedina yamilmedina added this pull request to the merge queue Aug 28, 2023
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Aug 28, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Aug 28, 2023
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 28, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 29, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 29, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Aug 29, 2023
Merged via the queue into develop with commit 7d65006 Aug 29, 2023
10 checks passed
@yamilmedina yamilmedina deleted the chore/crowdin-by-action branch August 29, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants