Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: map to mentions [WPB-4232] #2135

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: map to mentions [WPB-4232] #2135

merged 1 commit into from
Aug 28, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 25, 2023 •
edited
Loading

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

There was bad comparison for mapping mentions by checking string length

@Garzas Garzas requested a review from a team August 25, 2023 13:01
@Garzas Garzas self-assigned this Aug 25, 2023
@Garzas Garzas requested review from typfel, gongracr, borichellow, ohassine and saleniuk and removed request for a team August 25, 2023 13:01
@Garzas Garzas enabled auto-merge (squash) August 25, 2023 13:11
@github-actions
Copy link
Contributor

Test Results

583 tests   582 ✔️  8m 11s ⏱️
  84 suites      1 💤
  84 files        0 ❌

Results for commit 2c55834.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@Garzas Garzas merged commit 916c888 into release/candidate Aug 28, 2023
13 checks passed
@Garzas Garzas deleted the fix/mention-parsing branch August 28, 2023 15:56
github-actions bot pushed a commit that referenced this pull request Aug 28, 2023
@Garzas @github-actions
fix: map to mentions [WPB-4232] (#2135)
3b657a7
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel typfel approved these changes

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @typfel @alexandreferris @saleniuk