Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment of reactions [AR-3874] #2130

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Reactions options are a bit missaligned and skewed to the start of the screen

Solutions

Use Arrangement.SpaceEvenly to make sure it's all... evenly-spaced.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
image image

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods changed the title fix: alignment of reactions fix: alignment of reactions [AR-3874] Aug 23, 2023
@vitorhugods vitorhugods enabled auto-merge (squash) August 23, 2023 15:45
@github-actions
Copy link
Contributor

Test Results

556 tests   555 ✔️  24s ⏱️
  78 suites      1 💤
  78 files        0

Results for commit 013b7db.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1241 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods merged commit 4032c24 into release/candidate Aug 23, 2023
11 checks passed
@vitorhugods vitorhugods deleted the fix/reaction-alignment branch August 23, 2023 16:07
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants