Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cherry-pick): Unblock button is no longer visible when we block someone (WPB-2427) (RC) #2113

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ohassine
Copy link
Member

…-2427) (#2012)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Sister PR of #2012

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, gongracr, yamilmedina, alexandreferris and borichellow and removed request for a team August 18, 2023 09:11
@ohassine ohassine changed the title chore(cherry-pick): Unblock button is no longer visible when we block someone (WPB-2427) (RC) fix(cherry-pick): Unblock button is no longer visible when we block someone (WPB-2427) (RC) Aug 18, 2023
@ohassine ohassine enabled auto-merge (squash) August 18, 2023 09:23
@github-actions
Copy link
Contributor

Test Results

545 tests   544 ✔️  27s ⏱️
  77 suites      1 💤
  77 files        0

Results for commit 6c4ff0b.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1176 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 9fcca53 into release/candidate Aug 18, 2023
12 checks passed
@ohassine ohassine deleted the unblock_button_not_visible branch August 18, 2023 09:44
github-actions bot pushed a commit that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants