Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release action by grepping last matched result on tags #2109

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

yamilmedina
Copy link
Contributor

… the same hash


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

if there are 2 tags from the same hash, then the GH action to generate the change log will fail

Solutions

Get last match of the grepping tags on current commit HEAD result of git tag --points-at ${{github.sha}}

Bildschirmfoto 2023-08-16 um 21 45 21

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Aug 16, 2023
@yamilmedina yamilmedina requested review from MohamadJaara, a team, typfel, vitorhugods, Garzas and saleniuk and removed request for a team August 16, 2023 19:46
@github-actions
Copy link
Contributor

Test Results

555 tests  ±0   554 ✔️ ±0   5m 50s ⏱️ - 2m 6s
  80 suites ±0       1 💤 ±0 
  80 files   ±0       0 ±0 

Results for commit e0079aa. ± Comparison against base commit 6777126.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1149 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Aug 16, 2023
Merged via the queue into develop with commit e21fc7f Aug 16, 2023
11 checks passed
@yamilmedina yamilmedina deleted the fix/generate-changelog-from-tags branch August 16, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants