Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding participants adjustment strings and simplified (WPB-2297) #2105

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

This updates the copy for adding participants failure new message, simplified without detailing about unreachable but rather general as per new spec.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested review from a team, typfel, ohassine and saleniuk and removed request for a team August 16, 2023 09:46
Copy link
Contributor

@Garzas Garzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ✅ , just I don't know if we want to merge
mls_support_enabled disabled

@yamilmedina yamilmedina added this pull request to the merge queue Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2105 (b442d98) into develop (7e00519) will increase coverage by 0.67%.
Report is 2 commits behind head on develop.
The diff coverage is 75.67%.

@@              Coverage Diff              @@
##             develop    #2105      +/-   ##
=============================================
+ Coverage      39.63%   40.31%   +0.67%     
- Complexity       939      952      +13     
=============================================
  Files            305      305              
  Lines          11269    11290      +21     
  Branches        1506     1512       +6     
=============================================
+ Hits            4467     4551      +84     
+ Misses          6373     6302      -71     
- Partials         429      437       +8     
Files Changed Coverage Δ
...tlin/com/wire/android/migration/MigrationMapper.kt 0.00% <0.00%> (ø)
...lin/com/wire/android/mapper/UIParticipantMapper.kt 36.36% <16.66%> (-2.67%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 57.98% <89.47%> (+13.65%) ⬆️
.../wire/android/mapper/SystemMessageContentMapper.kt 65.78% <100.00%> (+29.82%) ⬆️
...ations/details/participants/model/UIParticipant.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1138c26...b442d98. Read the comment docs.

@github-actions
Copy link
Contributor

Test Results

546 tests  ±0   545 ✔️ ±0   5m 24s ⏱️ +20s
  80 suites ±0       1 💤 ±0 
  80 files   ±0       0 ±0 

Results for commit b442d98. ± Comparison against base commit 1138c26.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2023
@AndroidBob
Copy link
Collaborator

Build 1130 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Aug 16, 2023
Merged via the queue into develop with commit aa3bc1d Aug 16, 2023
10 checks passed
@yamilmedina yamilmedina deleted the feat/adding-participants-ajustment-fed branch August 16, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants