-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding participants adjustment strings and simplified (WPB-2297) #2105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ✅ , just I don't know if we want to merge
mls_support_enabled disabled
Codecov Report
@@ Coverage Diff @@
## develop #2105 +/- ##
=============================================
+ Coverage 39.63% 40.31% +0.67%
- Complexity 939 952 +13
=============================================
Files 305 305
Lines 11269 11290 +21
Branches 1506 1512 +6
=============================================
+ Hits 4467 4551 +84
+ Misses 6373 6302 -71
- Partials 429 437 +8
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1130 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
This updates the copy for adding participants failure new message, simplified without detailing about unreachable but rather general as per new spec.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.