feat: show connecting indicator if user has bad/lost connection during a call (WPB-1125) #2101

ohassine · 2023-08-15T09:31:05Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

This PR aims to display Connecting... indicator in the participant tile to indicate that the user has a bad/lost network durning a call. We also grey out the tile in that network state.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…g the call

github-actions · 2023-08-15T09:34:26Z

Test Results

557 tests ±0 556 ✔️ ±0 6m 47s ⏱️ -15s
  81 suites ±0     1 💤 ±0
  81 files ±0     0 ❌ ±0

Results for commit 6e2d94f. ± Comparison against base commit 3a65370.

♻️ This comment has been updated with latest results.

codecov · 2023-08-15T09:52:03Z

Codecov Report

Merging #2101 (69694f5) into develop (e8638e5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2101      +/-   ##
=============================================
+ Coverage      40.58%   40.59%   +0.01%     
  Complexity       975      975              
=============================================
  Files            309      309              
  Lines          11367    11369       +2     
  Branches        1519     1519              
=============================================
+ Hits            4613     4615       +2     
  Misses          6315     6315              
  Partials         439      439

Files Changed	Coverage Δ
...com/wire/android/mapper/UICallParticipantMapper.kt	`93.33% <100.00%> (+0.47%)`	⬆️
...wire/android/ui/calling/model/UICallParticipant.kt	`100.00% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8638e5...69694f5. Read the comment docs.

github-actions · 2023-08-15T09:59:03Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-15T10:18:19Z

Build 1092 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7312555)(7312555)-staging-compat.apk

github-actions · 2023-08-15T12:41:55Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-15T12:54:58Z

Build 1099 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7313527)(7313527)-staging-compat.apk

AndroidBob · 2023-08-15T13:10:32Z

Build 1099 failed.

AndroidBob · 2023-08-15T13:48:30Z

Build 1104 failed.

AndroidBob · 2023-08-15T14:57:21Z

Build 1110 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7314249)(7314249)-staging-compat.apk

github-actions · 2023-08-15T16:03:27Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-15T16:23:10Z

Build 1112 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7314758)(7314758)-staging-compat.apk

github-actions · 2023-08-16T07:51:57Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-16T08:11:16Z

Build 1122 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7320439)(7320439)-staging-compat.apk

AndroidBob · 2023-08-16T08:26:13Z

Build 1122 failed.

AndroidBob · 2023-08-16T09:31:53Z

Build 1125 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7320921)(7320921)-staging-compat.apk

app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt

github-actions · 2023-08-17T14:42:23Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-17T14:55:35Z

Build 1169 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7331520)(7331520)-staging-compat.apk

github-actions · 2023-08-17T16:05:01Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-17T16:22:17Z

Build 1170 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7332026)(7332026)-staging-compat.apk

github-actions · 2023-08-18T08:40:36Z

APKs built during tests are available here. Scroll down to Artifacts!

github-actions · 2023-08-18T09:09:38Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2023-08-18T09:31:03Z

Build 1175 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7338184)(7338184)-staging-compat.apk

Garzas

Nicelly done ✅ Just one comment about tests

Garzas · 2023-08-21T11:08:28Z

app/src/main/kotlin/com/wire/android/mapper/UICallParticipantMapper.kt

@@ -39,6 +39,7 @@ class UICallParticipantMapper @Inject constructor(
        isCameraOn = participant.isCameraOn,
        isSharingScreen = participant.isSharingScreen,
        avatar = participant.avatarAssetId?.let { ImageAsset.UserAvatarAsset(wireSessionImageLoader, it) },
-        membership = userTypeMapper.toMembership(participant.userType)
+        membership = userTypeMapper.toMembership(participant.userType),
+        hasEstablishedAudio = participant.hasEstablishedAudio


Can we write some test for it?

it's already tested in UICallParticipantMapperTest.kt

…ing_label_in_call # Conflicts: # app/src/main/res/values/strings.xml

AndroidBob · 2023-08-23T15:52:22Z

Build 1238 succeeded.

The build produced the following APK's:

com.wire.android-v4.4.0(7383680)(7383680)-staging-compat.apk

saleniuk · 2023-08-24T12:53:44Z

app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt

@@ -286,6 +288,7 @@ private fun UsernameTile(
    hasEstablishedAudio: Boolean
 ) {
    val color = if (isSpeaking) MaterialTheme.wireColorScheme.primary else Color.Black
+    val nameLabelColor = if (hasEstablishedAudio) Color.White else colorsScheme().secondaryText


thought: maybe we should move all these hard-coded to the theme colors as well, they would just be the same for both light and dark mode, but it would ensure we have all colors in one place so if we decide to change one of them we wouldn't need to look for them in the whole project

Well, not that simple by just changing the color in the file.. we need to check the whole project in all cases I would say especially for white and black

feat: show connecting indicator if user has bad/lost connection durin…

4b45048

…g the call

pull-request-size bot added the size/L label Aug 15, 2023

github-actions bot assigned ohassine Aug 15, 2023

chore: detekt

787a65b

Merge branch 'develop' into displaying_connecting_label_in_call

2838af2

ohassine requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and Garzas and removed request for a team August 15, 2023 12:17

alexandreferris approved these changes Aug 15, 2023

View reviewed changes

feat: use constraint layout to show connecting label

f6ddfcd

Merge branch 'develop' into displaying_connecting_label_in_call

af627a5

saleniuk reviewed Aug 16, 2023

View reviewed changes

app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt Show resolved Hide resolved

app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt Outdated Show resolved Hide resolved

ohassine requested a review from saleniuk August 17, 2023 14:15

Merge branch 'develop' into displaying_connecting_label_in_call

6b807f7

chore: update tile alpha

736ceba

ohassine requested a review from vitorhugods August 17, 2023 15:42

chore: address comments

2f7ff2f

Merge branch 'develop' into displaying_connecting_label_in_call

6e2d94f

Garzas approved these changes Aug 21, 2023

View reviewed changes

Merge remote-tracking branch 'origin/develop' into displaying_connect…

69694f5

…ing_label_in_call # Conflicts: # app/src/main/res/values/strings.xml

saleniuk reviewed Aug 24, 2023

View reviewed changes

saleniuk approved these changes Aug 24, 2023

View reviewed changes

ohassine added this pull request to the merge queue Aug 25, 2023

Merged via the queue into develop with commit 98a9f25 Aug 25, 2023
9 checks passed

ohassine deleted the displaying_connecting_label_in_call branch August 25, 2023 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: show connecting indicator if user has bad/lost connection during a call (WPB-1125) #2101

feat: show connecting indicator if user has bad/lost connection during a call (WPB-1125) #2101

ohassine commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

github-actions bot commented Aug 17, 2023

AndroidBob commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

AndroidBob commented Aug 17, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

AndroidBob commented Aug 18, 2023

Garzas left a comment

Garzas Aug 21, 2023

ohassine Aug 23, 2023

AndroidBob commented Aug 23, 2023

saleniuk Aug 24, 2023

ohassine Aug 25, 2023

feat: show connecting indicator if user has bad/lost connection during a call (WPB-1125) #2101

feat: show connecting indicator if user has bad/lost connection during a call (WPB-1125) #2101

Conversation

ohassine commented Aug 15, 2023 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Description

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Aug 15, 2023 • edited Loading

Test Results

codecov bot commented Aug 15, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 15, 2023

AndroidBob commented Aug 15, 2023

github-actions bot commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

AndroidBob commented Aug 16, 2023

github-actions bot commented Aug 17, 2023

AndroidBob commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

AndroidBob commented Aug 17, 2023

github-actions bot commented Aug 18, 2023

github-actions bot commented Aug 18, 2023

AndroidBob commented Aug 18, 2023

Garzas left a comment

Choose a reason for hiding this comment

Garzas Aug 21, 2023

Choose a reason for hiding this comment

ohassine Aug 23, 2023

Choose a reason for hiding this comment

AndroidBob commented Aug 23, 2023

saleniuk Aug 24, 2023

Choose a reason for hiding this comment

ohassine Aug 25, 2023

Choose a reason for hiding this comment

ohassine commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading