Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update use case package #2094

Closed
wants to merge 4 commits into from
Closed

chore: update use case package #2094

wants to merge 4 commits into from

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

RestartSlowSyncProcessForRecoveryUseCase package was changed in kalium, updating the path here as well

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested a review from Garzas August 11, 2023 16:09
@ohassine ohassine requested review from a team, typfel, borichellow, MohamadJaara and vitorhugods and removed request for a team August 11, 2023 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

Test Results

12 tests   - 521   12 ✔️  - 520   0s ⏱️ - 5m 33s
  3 suites  -   76     0 💤  -     1 
  3 files    -   76     0 ±    0 

Results for commit afc1c3e. ± Comparison against base commit 218494d.

This pull request removes 521 tests.
com.wire.android.GlobalObserversManagerTest ‑ given few valid accounts, when starting observing accounts, then create user-specific notification channels()
com.wire.android.GlobalObserversManagerTest ‑ given valid accounts, at least one with persistent socket enabled, and socket service running, then do not start service again()
com.wire.android.feature.AccountSwitchUseCaseTest ‑ givenCurrentSessionIsInvalid_whenSwitchingToAccount_thenUpdateCurrentSessionAndDeleteTheOldOne()
com.wire.android.feature.AccountSwitchUseCaseTest ‑ givenCurrentSessionIsValidAndNoOtherSessions_whenTryToSwitchToNextAccount_thenUpdateCurrentSessionAndReturnSuccessNoMoreAccounts()
com.wire.android.feature.AccountSwitchUseCaseTest ‑ givenCurrentSessionIsValid_whenSwitchingToAccountIsCalled_thenUpdateCurrentSessionAndReturnSuccessSwitchedToAnotherAccount()
com.wire.android.mapper.MessageContentMapperTest ‑ givenMessagesWithDifferentVisibilities_whenMappingToUIMessageContent_thenCorrectValuesShouldBeReturned()
com.wire.android.mapper.MessageMapperTest ‑ givenMessageList_whenMappingToUIMessages_thenCorrectValuesShouldBeReturned()
com.wire.android.mapper.MessageMapperTest ‑ givenMessagesList_whenGettingMemberIdList_thenReturnCorrectList()
com.wire.android.mapper.MessagePreviewContentMapperTest ‑ givenLastAssetAudioConversationMessage_whenMappingToUILastMessageContent_thenCorrectContentShouldBeReturned()
com.wire.android.mapper.MessagePreviewContentMapperTest ‑ givenLastAssetImageConversationMessage_whenMappingToUILastMessageContent_thenCorrectContentShouldBeReturned()
…

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1050 failed.

@AndroidBob
Copy link
Collaborator

Build 1059 failed.

@ohassine
Copy link
Member Author

To be fixed in #2067

@ohassine ohassine closed this Aug 14, 2023
auto-merge was automatically disabled August 14, 2023 09:08

Pull request was closed

@AndroidBob
Copy link
Collaborator

Build 1063 failed.

@ohassine ohassine deleted the update_package branch April 8, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants