-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(message): fix in-message embedded link validator (WPB-3554) #2089
fix(message): fix in-message embedded link validator (WPB-3554) #2089
Conversation
Build 1029 succeeded. The build produced the following APK's: |
Codecov Report
@@ Coverage Diff @@
## develop #2089 +/- ##
==========================================
Coverage 39.63% 39.63%
Complexity 939 939
==========================================
Files 305 305
Lines 11262 11269 +7
Branches 1506 1506
==========================================
+ Hits 4464 4467 +3
- Misses 6369 6373 +4
Partials 429 429
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1090 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Update the logic to check the embedded link in a message:
1- Show a visit link confirmation dialog when the user click on an embedded link
2- if the link starts with schema [anyString]://[anystring] we don't modify the link
ELSE -> add https:// to the link/text
Testing
Unit tests added
Test Coverage (Optional)
How to Test
Send a message with any combination of links you can imagine:
1- the visit link dialog, always must be appear
2- if the link misses the schema the shown link in the above dialog must start with https
3- if the link starts with schema, the shown link in the dialog must be the same as you posted
4- the app must not crash in any cases
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.