Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add audio asset metadata (WPB-3334) #2080

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

alexandreferris
Copy link
Contributor

Cherry pick from: #2075


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

ssues
When sending audio messages from Android it wouldn't render the audio length in Android and also other platforms

Causes (Optional)
We were not sending audio metadata.

Solutions
Add and map audio metadata correctly when sending the asset.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App
  • Open Conversation
  • Send Audio message and check:
    • Audio contains length before sending
    • Audio contains length on messages list
    • Audio contains length (check from other platforms Web/iOS)

@alexandreferris alexandreferris self-assigned this Aug 9, 2023
@alexandreferris alexandreferris requested review from a team, typfel, gongracr, borichellow, mchenani and trOnk12 and removed request for a team August 9, 2023 12:48
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2080 (293abd3) into develop (b741209) will increase coverage by 0.03%.
The diff coverage is 73.68%.

@@              Coverage Diff              @@
##             develop    #2080      +/-   ##
=============================================
+ Coverage      39.10%   39.14%   +0.03%     
  Complexity       920      920              
=============================================
  Files            305      305              
  Lines          11179    11194      +15     
  Branches        1490     1491       +1     
=============================================
+ Hits            4372     4382      +10     
- Misses          6386     6390       +4     
- Partials         421      422       +1     
Files Changed Coverage Δ
...id/ui/sharing/ImportMediaAuthenticatedViewModel.kt 0.00% <0.00%> (ø)
.../src/main/kotlin/com/wire/android/util/FileUtil.kt 0.00% <ø> (ø)
...essagecomposer/recordaudio/RecordAudioViewModel.kt 70.31% <80.00%> (+0.31%) ⬆️
.../ui/home/conversations/MessageComposerViewModel.kt 74.07% <100.00%> (+0.43%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b741209...293abd3. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test Results

509 tests  ±0   508 ✔️ ±0   6m 51s ⏱️ +47s
  77 suites ±0       1 💤 ±0 
  77 files   ±0       0 ±0 

Results for commit 293abd3. ± Comparison against base commit b741209.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@alexandreferris alexandreferris added this pull request to the merge queue Aug 9, 2023
@AndroidBob
Copy link
Collaborator

Build 993 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 3b7900e Aug 9, 2023
12 checks passed
@alexandreferris alexandreferris deleted the fix/add_audio_asset_metadata_cherry_pick branch August 9, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants