-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: attachment options in chat not working on android 14 (WPB-1846) #2073
fix: attachment options in chat not working on android 14 (WPB-1846) #2073
Conversation
APKs built during tests are available here. Scroll down to Artifacts! |
Build 962 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a kalium bump ?
No just was using old reference |
…working_on_Android_14
APKs built during tests are available here. Scroll down to Artifacts! |
Build 982 succeeded. The build produced the following APK's: |
…2073) Co-authored-by: Mateusz <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
User can't attach files on when using the app on Android 14
Causes (Optional)
On Android 14,
isImeVisible
is considering the attachments option layout as soft keyboard, causing to return wrong values when callingisKeyboardVisible()
Solutions
Use
isVisible
fromWindowInsetsCompat
onlyTesting
Test Coverage (Optional)
How to Test
You should be able to see the attachment options when you try to send a file using a device on Android 14.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.