Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachment options in chat not working on android 14 (WPB-1846) #2073

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Aug 8, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

User can't attach files on when using the app on Android 14

Causes (Optional)

On Android 14, isImeVisible is considering the attachments option layout as soft keyboard, causing to return wrong values when calling isKeyboardVisible()

Solutions

Use isVisible from WindowInsetsCompat only

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

You should be able to see the attachment options when you try to send a file using a device on Android 14.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Test Results

512 tests   511 ✔️  24s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit 04785e6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 962 succeeded.

The build produced the following APK's:

Copy link
Contributor

@trOnk12 trOnk12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a kalium bump ?

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Aug 9, 2023
@ohassine
Copy link
Member Author

ohassine commented Aug 9, 2023

there is a kalium bump ?

No just was using old reference

@ohassine ohassine enabled auto-merge (squash) August 9, 2023 10:22
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 982 succeeded.

The build produced the following APK's:

@ohassine ohassine merged commit 7047286 into release/candidate Aug 9, 2023
12 checks passed
@ohassine ohassine deleted the attachment_options_in_chat_not_working_on_Android_14 branch August 9, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants