fix: Keep screen active when user is recording audio (WPB-3479) #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
requested review from
a team,
typfel,
MohamadJaara,
vitorhugods,
Garzas and
trOnk12
and removed request for
a team
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 893 succeeded. The build produced the following APK's: |
trOnk12
approved these changes
Aug 3, 2023
saleniuk
reviewed
Aug 3, 2023
| @@ -100,6 +104,14 @@ fun RecordAudioButtonRecording( | |||
| seconds += 1 | |||
| } | |||
| } | |||
| val activity = LocalContext.current as Activity | |||
There was a problem hiding this comment.
There is a LocalActivity already, so it can be even val activity = LocalActivity.current 😎
There was a problem hiding this comment.
aaaaaaaa too late now :(
saleniuk
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When user was recording an audio, the screen would not be kept on and would lock the phone, thus stopping the recording.
Causes (Optional)
Not implemented.
Solutions
Add a disposable effect to add flag
FLAG_KEEP_SCREEN_ONwhen user is recording an audio, and dispose of the flag when it is ready to send or discarded.Testing
How to Test