Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more message status icons #2045

Closed
wants to merge 9 commits into from
Closed

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Aug 2, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Add support for read message status and delivered.

Needs releases with:

(wireapp/kalium#1943)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

image

image


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@trOnk12 looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
67514c7ec1394fbb477c9c3fb92600838f2642a5 ad652616b8ac3394a640a38822b47d5c900d2c38

Is this intentional?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Test Results

509 tests  ±0   508 ✔️ ±0   5m 37s ⏱️ -27s
  77 suites ±0       1 💤 ±0 
  77 files   ±0       0 ±0 

Results for commit ac950f9. ± Comparison against base commit b741209.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 840 failed.

@AndroidBob
Copy link
Collaborator

Build 863 failed.

@trOnk12 trOnk12 changed the title add more message status icons feat: add more message status icons Aug 3, 2023
@AndroidBob
Copy link
Collaborator

Build 917 failed.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2045 (ac950f9) into develop (b741209) will decrease coverage by 0.02%.
The diff coverage is 30.76%.

@@              Coverage Diff              @@
##             develop    #2045      +/-   ##
=============================================
- Coverage      39.10%   39.08%   -0.02%     
  Complexity       920      920              
=============================================
  Files            305      305              
  Lines          11179    11182       +3     
  Branches        1490     1494       +4     
=============================================
- Hits            4372     4371       -1     
- Misses          6386     6388       +2     
- Partials         421      423       +2     
Files Changed Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 60.78% <22.22%> (-1.85%) ⬇️
...e/android/ui/home/conversations/model/UIMessage.kt 43.98% <50.00%> (-0.35%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b741209...ac950f9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 949 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@trOnk12 trOnk12 closed this Aug 9, 2023
@trOnk12 trOnk12 reopened this Aug 9, 2023
@AndroidBob
Copy link
Collaborator

Build 986 succeeded.

The build produced the following APK's:

@trOnk12 trOnk12 closed this Aug 9, 2023
@trOnk12 trOnk12 deleted the feat/message_status branch August 9, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants