Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump junit:junit from 4.13 to 4.13.2 #2032

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 31, 2023

Bumps junit:junit from 4.13 to 4.13.2.

Release notes

Sourced from junit:junit's releases.

JUnit 4.13.2

Please refer to the release notes for details.

JUnit 4.13.1

Please refer to the release notes for details.

Changelog

Sourced from junit:junit's changelog.

Summary of changes in version 4.13.2

Rules

[Pull request #1687:](junit-team/junit#1687) Mark ThreadGroups created by FailOnTimeout as daemon groups

In JUnit 4.13 ([pull request #1517](junit-team/junit4#1517)) an attempt was made to fix leakage of the ThreadGroup instances created when a test is run with a timeout. That change explicitly destroyed the ThreadGroup that was created for the time-limited test. Numerous people reported problems that were caused by explicitly destroying the ThreadGroup.

In this change, the code was updated to call ThreadGroup.setDaemon(true) instead of destroying the ThreadGroup.

Pull request $1691: Only create ThreadGroups if FailOnTimeout.lookForStuckThread is true.

In JUnit 4.12 ([pull request #742](junit-team/junit4#742)) the Timeout Rule was updated to optionally display the stacktrace of the thread that appears to be stuck (enabled on an opt-in basis by passing true to Timeout.Builder.lookForStuckThread(boolean)). When that change was made, time-limited tests were changed to start the new thread in a new ThreadGroup, even if the test did not call lookForStuckThread(). This subtle change in behavior resulted in visible behavior changes to some tests (for example, tests of code that uses java.beans.ThreadGroupContext).

In this change, the code is updated to only create a new ThreadGroup if the caller calls Timeout.Builder.lookForStuckThread(true). Tests with timeouts that do not make this call will behave as they did in JUnit 4.11 (and more similar to tests that do not have a timeout). This unfortunately could result in visible changes of tests written or updated since the 4.12 release. If this change adversely affects your tests, you can create the Timeout rule via the builder and call Timeout.Builder.lookForStuckThread(true).

Exceptions

[Pull request #1654:](junit-team/junit#1654) Fix for issue #1192: NotSerializableException with AssumptionViolatedException

This change fixes an issue where AssumptionViolatedException instances could not be serialized if they were created with a constructor that takes in an org.hamcrest.Matcher instance (these constructors are used if you use one of the assumeThat() methods in org.junit.Assume).

Commits
  • 05fe2a6 [maven-release-plugin] prepare release r4.13.2
  • ff57344 Add build for JDK 17-ea
  • 02aaa01 Improve check that thread is stopped
  • e9a75f4 Merge test for exception type and message
  • d27ad52 Rename DelegateStatement to DelegatingStatement
  • b83dc2e Better name for test that stops statement
  • 527f3a3 Replace InfiniteLoop with RunForASecond
  • 2db6394 Tidy up FailOnTimeoutTest
  • 64634e1 Update 4.13.2 release notes to document pull 1654
  • f8ee412 Fix serialization of AssumptionViolatedException (#1654)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [junit:junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.2.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.2.md)
- [Commits](junit-team/junit4@r4.13...r4.13.2)

---
updated-dependencies:
- dependency-name: junit:junit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 31, 2023
@dependabot dependabot bot requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara and saleniuk and removed request for a team July 31, 2023 22:27
@github-actions
Copy link
Contributor

Test Results

518 tests  ±0   517 ✔️ ±0   21s ⏱️ -1s
  75 suites ±0       1 💤 ±0 
  75 files   ±0       0 ±0 

Results for commit 8febcca. ± Comparison against base commit f2182c9.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 784 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Aug 1, 2023
Merged via the queue into develop with commit 143eca0 Aug 1, 2023
9 checks passed
@ohassine ohassine deleted the dependabot/gradle/junit-junit-4.13.2 branch August 1, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants