feat: composable scoped view model and handle message buttom sheet menu #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2001) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Build 644 failed. |
MohamadJaara
changed the base branch from
develop
to
feat/composite_messages/epic
|
Build 647 failed. |
|
Build 648 failed. |
MohamadJaara
commented
Jul 25, 2023
Comment on lines
+57
to
63
| val onCopyItemClick: (() -> Unit)? = remember(message.header.messageId) { | ||
| (message.messageContent as? Copyable)?.textToCopy(localContext.resources)?.let { | ||
| { | ||
| hideEditMessageMenu { onCopyClick(it) } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The idea here is only Copyable messages will have the copy option displayed, and if we want to implement it to other messages we can do so by simply implementing the interface and we will be good to go
because before it will crash if it was called for anything that is not text message
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mohamad Jaara <[email protected]>
|
Build 651 failed. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
trOnk12
reviewed
Jul 25, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/model/MessageTypes.kt
Outdated
Show resolved
Hide resolved
trOnk12
reviewed
Jul 25, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/model/MessageTypes.kt
Outdated
Show resolved
Hide resolved
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 667 succeeded. The build produced the following APK's: |
trOnk12
reviewed
Jul 25, 2023
app/src/main/kotlin/com/wire/android/ui/home/conversations/model/MessageTypes.kt
Outdated
Show resolved
Hide resolved
trOnk12
approved these changes
Jul 25, 2023
MohamadJaara
merged commit e965629
into
feat/composite_messages/epic
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Causes (Optional)
Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.
Solutions
Briefly describe the solutions you have implemented for the issues explained above.
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.