fix: wrong pointerInput invoked on scroll inside message list

wireapp · Jul 28, 2023 · e4aeb14 · e4aeb14
1 parent 0b358cb
commit e4aeb14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/src/main/kotlin/com/wire/android/ui/common/ClickableText.kt b/app/src/main/kotlin/com/wire/android/ui/common/ClickableText.kt
@@ -64,7 +64,11 @@ fun ClickableText(
     val currentOnLongClick by rememberUpdatedState(newValue = onLongClick)
     val currentLayoutResult by rememberUpdatedState(layoutResult)
 
-    val pressIndicator = Modifier.pointerInput(Unit) {
+    // even though the rememberUpdateState, should be working, we still do not get the reference to the correct
+    // lambda's mainly when we scroll to the top of the list and then back to the bottom, it looks like, the reference
+    // does not get updated to point to the correct lambda. currentLayoutResult, should be good enough as the key
+    // because it should be updated with each "ClickableText" also we are referencing it inside pointerInput.
+    val pressIndicator = Modifier.pointerInput(currentLayoutResult.value) {
         detectTapGestures(
             onTap = { pos ->
                 currentLayoutResult.value?.let { layoutResult ->

diff --git a/kalium b/kalium