Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add leeway to iat & nbf [WPB-4947] #92

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: add leeway to iat & nbf [WPB-4947] #92

merged 3 commits into from
Nov 13, 2023

Conversation

beltram
Copy link
Contributor

@beltram beltram commented Oct 4, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Due to synchronization issues with backend adding a more important leeway fixes that.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram force-pushed the feat/wpb-4947 branch 2 times, most recently from 6d269a2 to 94a2179 Compare October 4, 2023 15:24
@beltram beltram merged commit df6b6a8 into main Nov 13, 2023
15 checks passed
@beltram beltram deleted the feat/wpb-4947 branch November 13, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@beltram