Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: miscellaneous breaking changes [WPB-5470] [WPB-5473] #103

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

beltram
Copy link
Contributor

@beltram beltram commented Nov 16, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • handle is format changed from im:wireapp={input} to im:wireapp=%40{input}@{domain}
  • WireIdentity contains JWK thumbprint of the certificate public key
  • WireIdentity contains a validation status (Valid/Expired/Revoked)

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram force-pushed the feat/e2ei-introspection branch from cbe40a0 to 693d428 Compare November 16, 2023 11:49
@beltram beltram changed the title feat: miscellaneous changes [WPB-5470] [WPB-5473] feat!: miscellaneous breaking changes [WPB-5470] [WPB-5473] Nov 16, 2023
@beltram beltram force-pushed the feat/e2ei-introspection branch from 693d428 to 47564b9 Compare November 16, 2023 12:08
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Merging #103 (001e0a3) into main (31474cf) will increase coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   82.49%   82.55%   +0.06%     
==========================================
  Files          60       62       +2     
  Lines        3884     3950      +66     
==========================================
+ Hits         3204     3261      +57     
- Misses        680      689       +9     

@beltram beltram force-pushed the feat/e2ei-introspection branch 3 times, most recently from 001e0a3 to 97e2a5b Compare November 16, 2023 13:33
acme/src/identity/status.rs Outdated Show resolved Hide resolved
@beltram beltram force-pushed the feat/e2ei-introspection branch from 97e2a5b to 2160354 Compare November 16, 2023 13:40
* handle is format changed from 'im:wireapp={input}' to 'im:wireapp=%40{input}@{domain}'
* WireIdentity contains JWK thumbprint of the certificate public key
* WireIdentity contains a validation status (Valid/Expired/Revoked)
@beltram beltram force-pushed the feat/e2ei-introspection branch from 2160354 to 632ac4f Compare November 16, 2023 13:40
@beltram beltram merged commit ea51f34 into main Nov 16, 2023
14 of 15 checks passed
@beltram beltram deleted the feat/e2ei-introspection branch November 16, 2023 13:45
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. Fix PR Title 🤦‍♂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants