Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(calling): add missing proguard rules #3095

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 7, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It not possible to build a release build with the latest version

ERROR: R8: Missing class org.webrtc.CalledByNative (referenced from: android.media.AudioManager org.webrtc.audio.WebRtcAudioManager.getAudioManager(android.content.Context) and 27 other contexts)
Missing class org.webrtc.JniCommon (referenced from: void org.webrtc.audio.JavaAudioDeviceModule.release())
Missing class org.webrtc.audio.AudioDeviceModule (referenced from: org.webrtc.audio.JavaAudioDeviceModule)

Solutions

Add missing rules

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title chore: add missing proguard rules chore(calling): add missing proguard rules Nov 7, 2024
@ohassine ohassine requested review from a team, m-zagorski, alexandreferris, MohamadJaara, Garzas and saleniuk and removed request for a team November 7, 2024 11:03
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Test Results

3 258 tests  ±0   3 151 ✅ ±0   5m 9s ⏱️ +26s
  557 suites ±0     107 💤 ±0 
  557 files   ±0       0 ❌ ±0 

Results for commit d681c64. ± Comparison against base commit 71ecfab.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🐰 Bencher Report

Branchmissing-proguard-rules
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
667,044.10
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
322,259,218.55
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
930,353,893.64
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,455,164.62
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.59%. Comparing base (71ecfab) to head (d681c64).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3095      +/-   ##
===========================================
- Coverage    52.59%   52.59%   -0.01%     
===========================================
  Files         1323     1323              
  Lines        51587    51587              
  Branches      4783     4783              
===========================================
- Hits         27131    27130       -1     
- Misses       22493    22494       +1     
  Partials      1963     1963              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ecfab...d681c64. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 7, 2024

Datadog Report

Branch report: missing-proguard-rules
Commit report: e6a7411
Test service: kalium-jvm

✅ 0 Failed, 3151 Passed, 107 Skipped, 37.39s Total Time

Copy link

sonarcloud bot commented Nov 7, 2024

@ohassine ohassine added this pull request to the merge queue Nov 7, 2024
Merged via the queue into develop with commit bbe46d0 Nov 7, 2024
21 of 22 checks passed
@ohassine ohassine deleted the missing-proguard-rules branch November 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants