Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logging for backups (WPB-12113) #3093

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 6, 2024

TaskWPB-12113 [Android] Improve logging for backups


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Logging was not being performed for importing backups

Causes (Optional)

Difficulty to troubleshoot problems related to it

Solutions

Implement logging, to add more info about failures.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Fail to import a backup, you should see more info related to the failure.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 6, 2024
@echoes-hq echoes-hq bot added the echoes: technical-debt Changes intended at mitigating risks label Nov 6, 2024
@yamilmedina yamilmedina requested review from Garzas, ohassine, a team, m-zagorski, alexandreferris and mathias-niboulies and removed request for a team November 6, 2024 13:49
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Results

3 252 tests  ±0   3 145 ✅ ±0   4m 16s ⏱️ +7s
  555 suites ±0     107 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 46080c7. ± Comparison against base commit 85c189c.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 6, 2024

Datadog Report

Branch report: chore/improv-backup-logging
Commit report: 1df4065
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 107 Skipped, 29.7s Total Time

Copy link

sonarcloud bot commented Nov 6, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.58%. Comparing base (85c189c) to head (46080c7).

Files with missing lines Patch % Lines
...alium/logic/feature/backup/RestoreBackupUseCase.kt 71.42% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3093   +/-   ##
==================================================
  Coverage              52.57%   52.58%           
==================================================
  Files                   1319     1319           
  Lines                  51475    51483    +8     
  Branches                4778     4778           
==================================================
+ Hits                   27065    27072    +7     
  Misses                 22449    22449           
- Partials                1961     1962    +1     
Files with missing lines Coverage Δ
...um/logic/feature/backup/RestoreWebBackupUseCase.kt 82.60% <100.00%> (+1.07%) ⬆️
...alium/logic/feature/backup/RestoreBackupUseCase.kt 71.92% <71.42%> (+1.02%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85c189c...46080c7. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Nov 7, 2024
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Nov 7, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Nov 7, 2024
Merged via the queue into release/candidate with commit 83207c7 Nov 7, 2024
20 checks passed
@yamilmedina yamilmedina deleted the chore/improv-backup-logging branch November 7, 2024 11:36
github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
* chore: improve logging for backups

* chore: improve logging for backups

* chore: detekt
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2024
* chore: improve logging for backups (WPB-12113) (#3093)

* chore: improve logging for backups

* chore: improve logging for backups

* chore: detekt

* chore: empty commit bump

---------

Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants