Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump avs version to 9.10.16 #3091

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: bump avs version to 9.10.16 #3091

merged 1 commit into from
Nov 6, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 6, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Bumping AVS version to 9.10.16

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Nov 6, 2024

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Test Results

3 260 tests  ±0   3 154 ✅ ±0   4m 23s ⏱️ +32s
  557 suites ±0     106 💤 ±0 
  557 files   ±0       0 ❌ ±0 

Results for commit 22b2b49. ± Comparison against base commit 4667ea7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🐰 Bencher Report

Branchavs-9.10.16
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
659,392.54
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
339,417,770.34
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
924,809,275.51
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,552,036.04
🐰 View full continuous benchmarking report in Bencher

@ohassine ohassine added this pull request to the merge queue Nov 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (4667ea7) to head (22b2b49).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3091   +/-   ##
========================================
  Coverage    52.72%   52.72%           
========================================
  Files         1321     1321           
  Lines        51209    51209           
  Branches      4748     4748           
========================================
+ Hits         27001    27002    +1     
+ Misses       22282    22280    -2     
- Partials      1926     1927    +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4667ea7...22b2b49. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: avs-9.10.16
Commit report: 8b63bf1
Test service: kalium-jvm

✅ 0 Failed, 3154 Passed, 106 Skipped, 34.98s Total Time

Merged via the queue into develop with commit 77bf609 Nov 6, 2024
22 of 23 checks passed
@ohassine ohassine deleted the avs-9.10.16 branch November 6, 2024 11:52
@echoes-hq echoes-hq bot added the echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements 👕 size: XS type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants