refactor: optimise paginated conversation list queries [WPB-11808]

[saleniuk]

WPB-11808 [Android] app stalls when fetching a page of conversations from the local DB

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

The app stalls when fetching a page of conversations from the local DB.

Causes (Optional)

Our queries for fetching conversation list pages are very complex, many joins with different tables resulting in full table scans, especially Message table.

Solutions

Optimised queries, joins made directly instead of using views so that it doesn't make full scans but just searches using existing indexes. Also rearranged joins to get self user so that it's executed once and not 4 times
Removed all unnecessary joins from query that only counts elements.
Moved ConversationDetails and ConversationDetailsWithEvents views to dedicated files along with all queries related to them and unify naming of functions.
Making a search with wildcard character % at the beginning results in full table scan of conversations (https://www.sqlite.org/optoverview.html#the_like_optimization) so now it's separated by creating two functions: for searching conversations with query and just fetching without searching, so that it doesn't scan if it's not actually necessary.

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Check how query is executed by calling EXPLAIN QUERY PLAN... or just open the app and scroll the conversations.

Attachments (Optional)

Query before:

Query after:

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 251 tests  ±0   3 145 ✅ ±0   4m 13s ⏱️ -11s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit 714003c. ± Comparison against base commit df1b199.

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: refactor/optimise-conversation-list-queries
Commit report: 97d0d51
Test service: kalium-jvm

✅ 0 Failed, 3145 Passed, 106 Skipped, 30.39s Total Time

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/candidate@96044bc). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...onversation/ConversationDetailsWithEventsMapper.kt	66.66%	0 Missing and 3 partials ⚠️
.../logic/data/conversation/ConversationRepository.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##             release/candidate    #3074   +/-   ##
====================================================
  Coverage                     ?   52.55%           
====================================================
  Files                        ?     1318           
  Lines                        ?    51445           
  Branches                     ?     4772           
====================================================
  Hits                         ?    27039           
  Misses                       ?    22445           
  Partials                     ?     1961           

Files with missing lines	Coverage Δ
...um/persistence/dao/conversation/ConversationDAO.kt	100.00% <ø> (ø)
...ersistence/dao/conversation/ConversationDAOImpl.kt	72.98% <100.00%> (ø)
...istence/dao/conversation/ConversationExtensions.kt	97.61% <100.00%> (ø)
...persistence/dao/conversation/ConversationMapper.kt	97.87% <ø> (ø)
...om/wire/kalium/persistence/dao/member/MemberDAO.kt	71.02% <100.00%> (ø)
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt	80.89% <100.00%> (ø)
.../logic/data/conversation/ConversationRepository.kt	62.03% <0.00%> (ø)
...onversation/ConversationDetailsWithEventsMapper.kt	92.55% <66.66%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96044bc...714003c. Read the comment docs.