Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra info for users without avatars in missing places (WPB-1750) #2977

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 28, 2024

StoryWPB-1750 [User avatar] Handle user avatars for users without user image


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to show. For users without avatars (they never got, defined one) to use the initials of their name and the accentColor they have.

Causes (Optional)

Paying an UX debt.

Solutions

Add the missing info to the places we need, mainly accent color.
An upcoming PR will follow in AR.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 28, 2024
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, vitorhugods and saleniuk and removed request for a team August 28, 2024 15:59
Copy link
Contributor

github-actions bot commented Aug 28, 2024

Test Results

3 186 tests  ±0   3 081 ✔️ ±0   3m 11s ⏱️ - 1m 4s
   548 suites ±0      105 💤 ±0 
   548 files   ±0          0 ±0 

Results for commit cb2d91a. ± Comparison against base commit 889708d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 28, 2024

🐰Bencher

ReportThu, August 29, 2024 at 21:39:23 UTC
Projectkalium
Branchfeat/users-without-avatars
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)677,595.03
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)340,580,109.15
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)925,580,712.53
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,407,023.28

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 28, 2024

Datadog Report

Branch report: feat/users-without-avatars
Commit report: 3834959
Test service: kalium-jvm

✅ 0 Failed, 3081 Passed, 105 Skipped, 9.68s Total Time

Copy link

sonarcloud bot commented Aug 29, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (889708d) to head (cb2d91a).

Files with missing lines Patch % Lines
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 0.00% 6 Missing ⚠️
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% 2 Missing ⚠️
...lin/com/wire/kalium/logic/data/call/Participant.kt 0.00% 1 Missing ⚠️
...otlin/com/wire/kalium/logic/data/user/UserModel.kt 0.00% 1 Missing ⚠️
...lium/logic/data/conversation/ConversationMapper.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2977      +/-   ##
===========================================
- Coverage    52.51%   52.49%   -0.02%     
===========================================
  Files         1295     1295              
  Lines        49735    49757      +22     
  Branches      4635     4641       +6     
===========================================
+ Hits         26116    26120       +4     
- Misses       21746    21761      +15     
- Partials      1873     1876       +3     
Files with missing lines Coverage Δ
...tlin/com/wire/kalium/logic/data/user/UserMapper.kt 54.60% <100.00%> (+0.15%) ⬆️
.../kotlin/com/wire/kalium/persistence/dao/UserDAO.kt 96.33% <100.00%> (+0.03%) ⬆️
...persistence/dao/conversation/ConversationMapper.kt 97.89% <100.00%> (+0.02%) ⬆️
...istence/dao/conversation/ConversationViewEntity.kt 97.87% <100.00%> (+0.04%) ⬆️
...lin/com/wire/kalium/logic/data/call/Participant.kt 0.00% <0.00%> (ø)
...otlin/com/wire/kalium/logic/data/user/UserModel.kt 0.00% <0.00%> (ø)
...lium/logic/data/conversation/ConversationMapper.kt 58.92% <0.00%> (-0.26%) ⬇️
...wire/kalium/logic/data/call/CallMetadataProfile.kt 0.00% <0.00%> (ø)
...lin/com/wire/kalium/persistence/dao/UserDAOImpl.kt 52.49% <0.00%> (-0.51%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889708d...cb2d91a. Read the comment docs.

@yamilmedina yamilmedina added this pull request to the merge queue Aug 30, 2024
Merged via the queue into develop with commit eeadc6d Aug 30, 2024
22 checks passed
@yamilmedina yamilmedina deleted the feat/users-without-avatars branch August 30, 2024 09:05
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
…-1750) (#2977)

* feat: add info for users without avatars handling

* feat: add unknown accent if not defined

* feat: missing parts in view

* feat: missing parts in view

* chore: add missing accent for convos

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants