-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make interaction availability as extension function [WPB-3176] #2970
Conversation
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Datadog ReportBranch report: ✅ 0 Failed, 3067 Passed, 105 Skipped, 9.95s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2970 +/- ##
===========================================
- Coverage 52.55% 52.52% -0.03%
===========================================
Files 1294 1294
Lines 49620 49634 +14
Branches 4609 4618 +9
===========================================
- Hits 26076 26069 -7
- Misses 21676 21697 +21
Partials 1868 1868
Continue to review full report in Codecov by Sentry.
|
otherUser.defederated -> InteractionAvailability.DISABLED | ||
otherUser.deleted -> InteractionAvailability.DELETED_USER | ||
otherUser.connectionStatus == ConnectionState.BLOCKED -> InteractionAvailability.BLOCKED_USER | ||
conversation.legalHoldStatus == com.wire.kalium.logic.data.conversation.Conversation.LegalHoldStatus.DEGRADED -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have the import at the top?
Quality Gate passedIssues Measures |
…76] (#2970) * refactor: make interaction availability as extension function * imports fix * review fixes
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Make
interactionAvailability
as an extension function forConversationDetails
to make it available to other places likeImportMediaAuthenticatedViewModel