Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make interaction availability as extension function [WPB-3176] #2970

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Aug 26, 2024

BugWPB-3176 I can share assets from outside of the app into a conversation that i left


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Make interactionAvailability as an extension function for ConversationDetails to make it available to other places like ImportMediaAuthenticatedViewModel

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Test Results

3 172 tests  ±0   3 067 ✔️ ±0   3m 9s ⏱️ -5s
   545 suites ±0      105 💤 ±0 
   545 files   ±0          0 ±0 

Results for commit 058b045. ± Comparison against base commit 770f49f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 26, 2024

🐰Bencher

ReportTue, August 27, 2024 at 10:41:46 UTC
Projectkalium
Branchrefactor/interaction-availability
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)687,619.35
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)539,606,893.54
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)922,931,364.24
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,262,954.23

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 26, 2024

Datadog Report

Branch report: refactor/interaction-availability
Commit report: 9863c64
Test service: kalium-jvm

✅ 0 Failed, 3067 Passed, 105 Skipped, 9.95s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (770f49f) to head (058b045).

Files Patch % Lines
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2970      +/-   ##
===========================================
- Coverage    52.55%   52.52%   -0.03%     
===========================================
  Files         1294     1294              
  Lines        49620    49634      +14     
  Branches      4609     4618       +9     
===========================================
- Hits         26076    26069       -7     
- Misses       21676    21697      +21     
  Partials      1868     1868              
Files Coverage Δ
...serveConversationInteractionAvailabilityUseCase.kt 82.60% <ø> (-4.06%) ⬇️
...ire/kalium/logic/data/conversation/Conversation.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 770f49f...058b045. Read the comment docs.

otherUser.defederated -> InteractionAvailability.DISABLED
otherUser.deleted -> InteractionAvailability.DELETED_USER
otherUser.connectionStatus == ConnectionState.BLOCKED -> InteractionAvailability.BLOCKED_USER
conversation.legalHoldStatus == com.wire.kalium.logic.data.conversation.Conversation.LegalHoldStatus.DEGRADED ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have the import at the top?

Copy link

sonarcloud bot commented Aug 27, 2024

@Garzas Garzas enabled auto-merge August 27, 2024 10:40
@Garzas Garzas disabled auto-merge August 27, 2024 10:41
@Garzas Garzas added this pull request to the merge queue Aug 28, 2024
Merged via the queue into develop with commit afb1b05 Aug 28, 2024
22 checks passed
@Garzas Garzas deleted the refactor/interaction-availability branch August 28, 2024 07:51
MohamadJaara pushed a commit that referenced this pull request Oct 18, 2024
…76] (#2970)

* refactor: make interaction availability as extension function

* imports fix

* review fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants