fix: Call ending when enabling video during a 1:1 call in 1:1 MLS conversation (WPB-10724) #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohassine
requested review from
a team,
yamilmedina,
alexandreferris,
borichellow,
vitorhugods and
saleniuk
and removed request for
a team
|
Datadog ReportBranch report: ✅ 0 Failed, 3075 Passed, 105 Skipped, 9.51s Total Time |
No, 4.6 has the fix already |
Garzas
approved these changes
Aug 23, 2024
borichellow
approved these changes
Aug 23, 2024
echoes-hq
bot
added
the
echoes: bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Call ending when enabling video during a 1:1 call on SFT in 1:1 MLS conversation
Causes (Optional)
AVS is resetting
aestabto 0 value causing all participants to go to reconnecting state. As for 1:1 calls on SFT, we rely on aestab value to end the call, the call ends immediately when the user turns his camera.Solutions
The issue is fixed on AVS, fixing that aestab glitch when re-connecting for video
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.