Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support api v6 [WPB-10265] #2940

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

support api v6

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Aug 9, 2024
@MohamadJaara MohamadJaara requested review from a team, typfel, yamilmedina, alexandreferris, vitorhugods and saleniuk and removed request for a team August 9, 2024 07:55
Copy link

sonarcloud bot commented Aug 9, 2024

@MohamadJaara MohamadJaara enabled auto-merge (squash) August 9, 2024 07:55
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Test Results

2 922 tests   2 799 ✔️  26s ⏱️
   496 suites     123 💤
   496 files           0

Results for commit be02d30.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/support-api-6
Commit report: 2823bef
Test service: kalium-jvm

✅ 0 Failed, 2947 Passed, 107 Skipped, 5.02s Total Time

@MohamadJaara MohamadJaara merged commit e1f7b28 into release/android-cycle-4.6 Aug 9, 2024
20 checks passed
@MohamadJaara MohamadJaara deleted the feat/support-api-6 branch August 9, 2024 08:18
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value 👕 size: XS type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants