Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset restriction [WPB-9947] (#2831) (#2856) #2861

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

MohamadJaara
Copy link
Member

  • fix: asset restriction (fix: asset restriction #2831)

  • fix: asset sending restriction

  • add test

  • add error messages and detekt

  • fist test service

  • detekt

  • chore: update gradle-ios-tests.yml for runner at that time


Co-authored-by: Yamil Medina [email protected]

(cherry picked from commit ebcc9f8)

  • fix merge issues

  • fix unresolved reference

(cherry picked from commit 116f276)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When sending a new file, assets restrictions are not considered.

Solutions

check the file restrictions status and return the correct error based on that

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* fix: asset restriction (#2831)

* fix: asset sending restriction

* add test

* add error messages and detekt

* fist test service

* detekt

* chore: update gradle-ios-tests.yml for runner at that time

---------

Co-authored-by: Yamil Medina <[email protected]>

(cherry picked from commit ebcc9f8)

* fix merge issues

* fix unresolved reference

(cherry picked from commit 116f276)
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test Results

2 880 tests   2 862 ✔️  4m 8s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit 81429be.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Jul 2, 2024

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jul 2, 2024

Datadog Report

All test runs d4edfe3 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2767 123 1.3s Link
kalium-jvm 0 0 0 2908 107 6.7s Link

@MohamadJaara MohamadJaara merged commit 596eb02 into release/android-cycle-4.6 Jul 3, 2024
18 checks passed
@MohamadJaara MohamadJaara deleted the fix/asset-restriction-4.6 branch July 3, 2024 10:07
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants