-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reimplement update api versions usecase to use proxy #2414
refactor: reimplement update api versions usecase to use proxy #2414
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.4.x #2414 +/- ##
==============================================================
Coverage ? 58.10%
Complexity ? 21
==============================================================
Files ? 1011
Lines ? 37996
Branches ? 3457
==============================================================
Hits ? 22077
Misses ? 14443
Partials ? 1476 Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
e4347e4
into
fix/proxy-mode-does-not-apply-to-all-api-points
* fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests
* fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457)
) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test
* fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457)
) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test (cherry picked from commit 5651bb1)
* fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * fix: merge issues * fix: some end points are not routed through the proxy server v4.5 (#2485) * fix: some end points are not routed through the proxy server (#2400) * fix: some end points are not routed through the proxy server * fix cli * fix android sample * fix test service * detekt * fix ios target * fix tests * refactor: reimplement update api versions usecase to use proxy (#2414) * refactor: implement UpdateApiVersionsUseCaseImpl to be proxy safe * feat: add proxy URL and need auth indication to custom server dialogs * fix tests (cherry picked from commit b1f1457) * fix cherry pick issues * detekt * trigger CI * fix import * fix test (cherry picked from commit 5651bb1) * fix: merge issues * cleanup logs * address PR comments --------- Co-authored-by: Alexandre Ferris <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
UpdateApiVersionsUseCase is not proxy safe
Solutions
reimplement it and make sure to respect server config proxy
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.