feat(monkeys): Add new configuration attributes for the next milestone [WPB-3353] #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1911 +/- ##
=============================================
- Coverage 56.07% 56.07% -0.01%
Complexity 35 35
=============================================
Files 987 987
Lines 36873 36873
Branches 3315 3315
=============================================
- Hits 20677 20675 -2
- Misses 14814 14816 +2
Partials 1382 1382 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
augustocdias
force-pushed
the
feat/monkeys/new-config
branch
from
1bf8793
to
3a2d6ac
Compare
vitorhugods
approved these changes
Jul 24, 2023
Comment on lines
+38
to
+47
| @Serializable | ||
| sealed class UserCount { | ||
| @Serializable | ||
| @SerialName("PERCENTAGE") | ||
| data class Percentage(@SerialName("value") val value: UInt) : UserCount() | ||
|
|
||
| @Serializable | ||
| @SerialName("FIXED_COUNT") | ||
| data class FixedCount(@SerialName("value") val value: UInt) : UserCount() | ||
| } |
There was a problem hiding this comment.
Just as a heads up, this will require an implicit type field in order for Kotlinx-serialization to select which one is being deserialized.
"userCount": {
"type": "PERCENTAGE",
"value": 48
}"userCount": {
"type": "FIXED_COUNT",
"value": 1000
}I like it :)
monkeys/src/commonMain/kotlin/com/wire/kalium/monkeys/importer/TestData.kt
Outdated
Show resolved
Hide resolved
…/TestData.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
typfel
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
In order to enable extensibility and more use cases we're adding new configuration options for the application.
Causes (Optional)
Right now the application is with most of its parameters hardcoded, not allowing many test scenarios.
Notes (Optional)
This is the first iteration on this. The logic for handling the configuration will come in separate PRs to not have huge code reviews.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.