Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore .run directory #1910

Merged
merged 1 commit into from
Jul 24, 2023
Merged

chore: ignore .run directory #1910

merged 1 commit into from
Jul 24, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Jul 24, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

I've created my own personally configured run tasks which gets persisted to .run so I think it makes sense to add it to .gitignore


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Unit Test Results

   405 files  ±0     405 suites  ±0   2m 11s ⏱️ +18s
2 189 tests ±0  2 091 ✔️ ±0  98 💤 ±0  0 ±0 

Results for commit 94355ae. ± Comparison against base commit aaefb3a.

♻️ This comment has been updated with latest results.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever want to share run settings, we can explicitly add them on git ignore with the ! mark I guess

@typfel typfel merged commit 8572b17 into develop Jul 24, 2023
10 checks passed
@typfel typfel deleted the chore/run-git-ignore branch July 24, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants