-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade kotlin to 1.9.0 #1907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required: - compose-compiler from 1.4.7 to 1.5.0 - support the new Android SourceSet Layout (androidAndroidTest -> androidInstrumentedTest, for example).
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1907 +/- ##
=============================================
+ Coverage 55.05% 56.07% +1.02%
+ Complexity 1631 35 -1596
=============================================
Files 1014 985 -29
Lines 37365 36744 -621
Branches 3359 3289 -70
=============================================
+ Hits 20571 20606 +35
+ Misses 15425 14759 -666
- Partials 1369 1379 +10 see 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MohamadJaara
approved these changes
Jul 23, 2023
typfel
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Kotlin 1.9.0 is released. We're just a tiny bit behind.
We could benefit, from some stuff like
data object
.Better to upgrade little-by-little than being forced to upgrade everything at once.
Solutions
Upgrade it!
Required:
Testing
Did run this + Reloaded locally. Ran some tests too, everything seems OK.
Only missing coverage reports, etc. to make sure
kover
works.Test Coverage
N/A
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.