Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade kotlin to 1.9.0 #1907

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Kotlin 1.9.0 is released. We're just a tiny bit behind.

We could benefit, from some stuff like data object.

Better to upgrade little-by-little than being forced to upgrade everything at once.

Solutions

Upgrade it!

Required:

Testing

Did run this + Reloaded locally. Ran some tests too, everything seems OK.

Only missing coverage reports, etc. to make sure kover works.

Test Coverage

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Required:
- compose-compiler from 1.4.7 to 1.5.0
- support the new Android SourceSet Layout (androidAndroidTest -> androidInstrumentedTest, for example).
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Unit Test Results

       6 files   - 399         6 suites   - 399   8m 55s ⏱️ + 7m 19s
2 089 tests  - 100  2 072 ✔️  -   19  17 💤  - 81  0 ±0 

Results for commit d303b26. ± Comparison against base commit 82a1705.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #1907 (d303b26) into develop (82a1705) will increase coverage by 1.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1907      +/-   ##
=============================================
+ Coverage      55.05%   56.07%   +1.02%     
+ Complexity      1631       35    -1596     
=============================================
  Files           1014      985      -29     
  Lines          37365    36744     -621     
  Branches        3359     3289      -70     
=============================================
+ Hits           20571    20606      +35     
+ Misses         15425    14759     -666     
- Partials        1369     1379      +10     

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a1705...d303b26. Read the comment docs.

@vitorhugods vitorhugods merged commit aaefb3a into develop Jul 24, 2023
9 checks passed
@vitorhugods vitorhugods deleted the chore/upgrade-kotlin-to-1.9 branch July 24, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants