-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: keep client initialization state internal [WPB-12004] #749
Open
SimonThormeyer
wants to merge
8
commits into
feat/transaction
Choose a base branch
from
simon/chore/remove-client-lock
base: feat/transaction
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 7, 2024
-
refactor: keep client locks and state internal [WPB-12004]
This allows us to stop passing around a lock guard when accessing the client. Keeps all locking and initialization internal to the client struct.
Configuration menu - View commit details
-
Copy full SHA for 83e88db - Browse repository at this point
Copy the full SHA 83e88dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b233b9d - Browse repository at this point
Copy the full SHA b233b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 244b012 - Browse repository at this point
Copy the full SHA 244b012View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7b013d - Browse repository at this point
Copy the full SHA a7b013dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0c0923 - Browse repository at this point
Copy the full SHA f0c0923View commit details -
Configuration menu - View commit details
-
Copy full SHA for c173a83 - Browse repository at this point
Copy the full SHA c173a83View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e9c75 - Browse repository at this point
Copy the full SHA a9e9c75View commit details -
chore: fix resulting compile errors
Compile errors resulting from the changes to the mls client implementation
Configuration menu - View commit details
-
Copy full SHA for 42839c6 - Browse repository at this point
Copy the full SHA 42839c6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.