Improve button configuration / extensibility

[LukeTowers]

No description provided.

[goldmont]

Hi,

I would suggest also this change in views/buttons/provider to allow logo removal:

<div class="winter-sso">
    <a
        href="<?= e($url); ?>"
        class="flex items-center py-0 px-4 m-0 mt-4 w-full h-12 text-center normal-case bg-transparent bg-none rounded border border-cyan-700 border-solid cursor-pointer"
    >
	    <?php if ($logoUrl): ?>
			<div class="flex items-center font-sans leading-6 text-cyan-700">
				<div class="flex justify-center items-center w-8 h-8 text-center rounded-full bg-zinc-100">
						<img
							src="<?= e($logoUrl); ?>"
							alt="<?= e($logoAlt); ?>"
							class="block w-5 max-w-full h-5 align-middle"
						/>
				</div>
				<div class="mr-0 ml-3 w-px h-6 text-center bg-gray-400"></div>
			</div>
	    <?php endif; ?>
        <div class="flex-1 font-sans leading-6 text-cyan-700 <?= $logoUrl ? '-ml-9' : '' ?>">
            <p class="m-0 font-medium leading-7 cursor-pointer">
                <?= e($label); ?>
            </p>
        </div>
    </a>
</div>

[goldmont]

Furthermore, consider replacing Config::get('winter.sso::enabled_providers', []) with array_keys(Config::get('winter.sso::enabled_providers', [])) because now enabled_providers is an associative array.

Plugin.php:134
Plugin.php:162
controllers/Handle.php:56

Otherwise, let's create a new key... e.g. view_overrides

[LukeTowers]

@goldmont give the latest commits a try, I've moved the button config to the providers array instead of the enabled_providers so it shouldn't conflict anymore.

[goldmont]

Hi,

It's ok to me. Consider removing the -ml-9 class from the label container to make it properly centered.

[goldmont]

Also, is it possible to bumb the library to a stable version? In my composer.json I had to switch minimum-stability from stable to dev in order to install the library.

[goldmont]

@LukeTowers There is an error in the view as I pointed out in a previous comment.

[LukeTowers]

@goldmont which error?

[goldmont]

The first argument of View::make should be data["view"]

[LukeTowers]

@goldmont ah, thanks! Fixed in d6e998c