splat refactor and add metadataArray #85
Open
+306
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tagyoureit , this looks pretty good (there are some obvious nitpicks/style stuff to clean up before merging but no big deal)! Definitely want to go over this with @indexzero since this changes the behavior of splat/metadata (though arguably strictly improves metadata behavior), but I'm supportive of this design and think it makes sense as we discussed. |
|
I realized I didn't add the TypeScript definition for the the new formatter. I'm not a TS expert (but trying to learn). |
2 tasks
2 tasks
|
Can we get this merged in? Losing metadata from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@indexzero @DABH Here are my improvements to splat, metadata and the new metadataArray.