WINDUP-1560 Print a warning on the web console for large analysis #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizzi
changed the title
mrizzi
added
Work in Progress / for discussion
Ready to Review
and removed
Work in Progress / for discussion
labels
klinki
reviewed
Jul 26, 2017
|
I agree with you: maybe the best place to show such a notification is when starting a new analysis to inform the user that it could take a long time: in this way, we'll know all the applications involved in the analysis and so derive the best estimation for analysis's duration. Because if the 10 applications, 20 MB each, are uploaded together, we have a chance to sum their sizes but if the applications are uploaded in different times, then we know the total size of the applications only at "analysis time". |
|
I agree. I think it is more appropriate to show that message when analysis is started. (It would be also better for scenarios when user uploads applications and skips analysis and starts it later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works for uploaded application.