Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add g:FerretGrepCommand #46

Closed
wants to merge 1 commit into from
Closed

Add g:FerretGrepCommand #46

wants to merge 1 commit into from

Conversation

kriansa
Copy link

@kriansa kriansa commented Jul 5, 2017

This change adds a new command to customize the grep command executed by
Ferret under the hook. For more context, see:

#38

Copy link
Owner

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid. Thanks! I'll give this a proper review when I am at a computer, but this looks pretty good (it even has docs!).

@kriansa
Copy link
Author

kriansa commented Aug 21, 2017

Hello @wincent!
Sorry to bother you, but is there something I could do to help to get this merged? I know you're probably busy, but let me know if there's something in this PR that you didn't feel comfortable with so I can fix it.
Thanks!

This change adds a new command to customize the grep command executed by
Ferret under the hook. For more context, see:

#38
@kriansa
Copy link
Author

kriansa commented Jan 13, 2018

Hi @wincent, did you find time to review this PR?

@kriansa kriansa mentioned this pull request Jan 13, 2018
@kriansa
Copy link
Author

kriansa commented Apr 23, 2018

Hi @wincent,

Sorry to bother, it's just that this is going on for almost a year now and you didn't review it. I would like to know if this is still something that you care about (fixing #39). It's fine if you don't have interest, or if you find that this solution sucks, but I would like to get an answer. I make myself available if you think that this is not the right way to do it, or if you would like me to add more information. I just want to help.

Thanks for the awesome work on this project! 😄

@wincent wincent closed this in 09290a2 Dec 25, 2018
@wincent
Copy link
Owner

wincent commented Dec 25, 2018

Thanks for you work on this @kriansa. In order to address a broader set of use cases (see #55) I've merged in something that allows you to set the arguments for each executable as opposed to supplying a string that overrides the executable + the args. Hopefully this will meet the need you're addressing in this PR and also the one in the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants