fix: align beersmith definition to revised website #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They have split legacy versions off to a second page and redesigned the download page so replace dynamic parsing for now
philclifford
force-pushed
the
fix-beersmith
branch
from
cb0a56d
to
2b38286
Compare
Avoid cacheing megs of data we never look at. Since this is no longer json it would be better to rename the cache file and filter before writing, but that needs some refactoring to be achievable
Since this is no longer json we rename the cache file and filter before writing out
Changing the filename elsewhere broke this one definition that had not been updated. Also reworked the fallback logic to be more general, without reference to unsupported old releases.
|
Replaced by single fix in #1208 as test just fails with too many package updates (?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They have split legacy versions off to a second page and redesigned the download page so replace dynamic parsing for now
Fixes #1192