refactor: design system #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousinix
reviewed
Jul 1, 2024
Comment on lines
-45
to
-50
| - name: Deploy to demo.widgetbook.io | ||
| uses: google-github-actions/[email protected] | ||
| with: | ||
| path: widgetbook/build/web | ||
| destination: demo.widgetbook.io | ||
| parent: false |
There was a problem hiding this comment.
issue: This step is still needed, to host the changes on demo.widgetboo.io
| "https://www.figma.com/design/TQ3x8ohiB7XfUKSYeFVb7v/FlutterCon-'24?node-id=6809-5479&t=Jvcq3BxVyPK6l2OF-4", | ||
| ) | ||
| Widget buildBasketSummaryUseCase(BuildContext context) { | ||
| return BasketSummary( |
There was a problem hiding this comment.
question: Should we add some padding to the use-case?
We might also need to set mainAxisSize to MainAxisSize.min inside the BasketSummary widget, to make the vertical centering better.
Comment on lines
+1
to
6
| // ignore_for_file: unused_import | ||
|
|
||
| import 'package:flutter/widgets.dart'; | ||
| import 'package:groceries_app/core/core.dart'; | ||
| import 'package:widgetbook/widgetbook.dart'; | ||
| import 'package:widgetbook_annotation/widgetbook_annotation.dart'; |
There was a problem hiding this comment.
suggestion: I think we should keep the AppBar implemented in this repo, and create a flutter-con-24-challenge repo, with this component removed.
There was a problem hiding this comment.
👍🏻 I Accidentally pushed to the wrong repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design system got a litter refactoring to make it more structured. The changes can be viewed on Figma.
To see what exactly changed click on the arrow next to FlutterCon '24 [branch symbol] refactor and press Review and merge changes...