Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature branch #17

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/widgetbook-build-staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
flutter gen-l10n

- name: Install Widgetbook CLI
run: dart pub global activate widgetbook_cli
run: dart pub global activate -s git https://github.com/widgetbook/widgetbook.git --git-path packages/widgetbook_cli --git-ref feat/cli/visual-diff

- name: Build Widgetbook
working-directory: widgetbook
Expand All @@ -35,4 +35,4 @@ jobs:

- name: Upload Widgetbook
working-directory: widgetbook
run: widgetbook_staging publish --api-key ${{ secrets.WIDGETBOOK_CLOUD_API_KEY_STAGING }}
run: widgetbook_staging publish --api-key ${{ secrets.WIDGETBOOK_CLOUD_API_KEY_STAGING }} --experimental-visual-diff
50 changes: 0 additions & 50 deletions .github/workflows/widgetbook-build.yaml

This file was deleted.

5 changes: 3 additions & 2 deletions .github/workflows/widgetbook-review-staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
flutter gen-l10n

- name: Install Widgetbook CLI
run: dart pub global activate widgetbook_cli
run: dart pub global activate -s git https://github.com/widgetbook/widgetbook.git --git-path packages/widgetbook_cli --git-ref feat/cli/visual-diff

- name: Build Widgetbook
working-directory: widgetbook
Expand All @@ -42,4 +42,5 @@ jobs:
--actor $GITHUB_ACTOR \
--base-branch $GITHUB_BASE_REF \
--branch $GITHUB_HEAD_REF \
--commit ${{ github.event.pull_request.head.sha }}
--commit ${{ github.event.pull_request.head.sha }} \
--experimental-visual-diff
45 changes: 0 additions & 45 deletions .github/workflows/widgetbook-review.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion widgetbook/lib/core/primary_button.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Widget buildContinueButtonUseCase(BuildContext context) {
child: PrimaryButton(
content: context.knobs.string(
label: 'Content',
initialValue: 'Continue to Shipping',
initialValue: 'Continue to Shipping 2',
),
),
);
Expand Down
Loading