Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New events #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New events #15

wants to merge 1 commit into from

Conversation

urjagl
Copy link

@urjagl urjagl commented Jul 11, 2016

No description provided.

@fboxwala
Copy link
Collaborator

Hey Urja! This PR looks good, just a few small things to keep in mind for next time:

Your commit messages need to be descriptive of actions you took in this PR, and they need to be using present tense action verbs.

For example for this pr you would have something like "Adds event for technical interview workshop"

And the name of your file should follow the naming convention and placement convention of our other event files. You will see that all the events are in the directory content/{term #}/ and they all follow the naming convention {term #}-event-eventname.md

If you don't do this correctly the event post will not render in the right place on the website.

Since this was just a practice PR I dont expect you to make these changes, but just so you know for the future. You can go ahead and work on the next steps I gave you now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants