Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list:
Description: It fixes this issue.
For a file
foo.rb
which has code:if we run
rubycritic foo.rb
, all the smells it reports is labelled under fileFoo::Jj
. Which is not right. For example: for smells reported fordef bar(x,y,z)
should not be listed underFoo:Jj
as that class is closed. It should showFoo
.Snapshot of what it was before and after the change when we run
rubycritic foo.rb
Before:
After:
I think it makes more sense to show the class/module name extracted from the file name rather than showing a sub-class within that file for all the smells.