Issue 461 - Fix for churn score when accessed from a sub-directory #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishijain
force-pushed
the
issue461
branch
2 times, most recently
from
08aee26
to
59d86fb
Compare
rishijain
changed the title
* bug fix * reek fixes * updated changelog
etagwerker
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #461.
From my research, I understood that there are 2 ways to fix this.
When the score is already set for the paths, so when you are trying to fetch the churn score of a file, adjust the path of the file to match the file name that is being stored in the @stats variable.
Adjust the filename when the score is being set, and then fetch the score of the file without any manipulation.
I decided to go with 2nd approach as it seems more cleaner way of solving this.
Check list: